Add missing timeout in HTTP_Client request, in sr1() call#4751
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4751 +/- ##
=======================================
Coverage 82.15% 82.15%
=======================================
Files 361 361
Lines 87279 87279
=======================================
+ Hits 71701 71705 +4
+ Misses 15578 15574 -4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing HTTP request with HTTP_Client, request() mehod stucks in sr1() when the request is to a non HTTP port, e.g. HTTPS port. This happens even when timeout parameter is passed to request() method.
To fix this, I added timeout parameter passing to sr1() call to TCP socket. This prevents request() from stucking when timeout is passed as argument.